search

SmileYzn / MatchBot

Counter-Strike 1.6 Match Plugin for ReHLDS and ReGameDLL_CS
GNU General Public License v3.0
28 stars 14 forks source link

.votepause server crashed. #130

Closed Escap3d closed 6 months ago

Escap3d commented 6 months ago

Fix the server crash caused by using the .votepause command.

SmileYzn commented 6 months ago

image

Already fixed it.

Escap3d commented 6 months ago

Ok i am trying today because its job time.. :(

Escap3d commented 6 months ago

https://www.mediafire.com/file/wfesez9g5scl2kf/2024-02-16+20-42-30.mp4/file

plzz check it video its not fixed

SmileYzn commented 6 months ago

Video is wrong check it

Escap3d commented 6 months ago

Smiley brother, please watch the video again, the server is crashing. Using the votepause command...

Escap3d commented 6 months ago

Video is wrong check it

https://www.mediafire.com/file/mz3zryegxgrk3ub/2024-02-17+20-59-49.mp4/file

Check it again i am new video upload here

same happen on windows server Screenshot 2024-02-17 212822 @SmileYzn

SmileYzn commented 6 months ago

@Escap3d

.votepause is crashing only without players in server.

Check if mb_player_vote_pause is 5 in matchbot.cfg or a valid int number, as i said in other issue: Check if matchbot.cfg does not have an = (Equal symbom on mb_player_vote_pause)

That can cause crash in server

Escap3d commented 6 months ago

@Escap3d

.votepause is crashing only without players in server.

Check if mb_player_vote_pause is 5 in matchbot.cfg or a valid int number, as i said in other issue: Check if matchbot.cfg does not have an = (Equal symbom on mb_player_vote_pause)

That can cause crash in server

I am set on matxhbot.cfg limit on votepause command 1

Escap3d commented 6 months ago

Sorry i am disturbing u .. i ane using all commands of limited us matchbot.cfg

.votepause .voterestart .votesurrender .votekick .votemap And much for player vote jus like this

SmileYzn commented 6 months ago

Sorry i am disturbing u .. i ane using all commands of limited us matchbot.cfg

.votepause .voterestart .votesurrender .votekick .votemap And much for player vote jus like this

I did not understand, what this is related to crash?

Escap3d commented 6 months ago

Sorry i am disturbing u .. i ane using all commands of limited us matchbot.cfg

.votepause .voterestart .votesurrender .votekick .votemap And much for player vote jus like this

I want to say that the vote commands used during a live match can be restricted to a limited number of players so that it doesn't require all players to vote. I have limited the voting in the match bot config to avoid crashes like the one that occurred with the pause command.

SmileYzn commented 6 months ago

Crashes occurs because of incorrect values in matchbot variables. It already been fixed .votepause and other commands.

A VOTE in matchbot requires a least 3 of 5 players or 6 of 10 players.

If a vote is per team .votekick or per all players in server like .votemap.

Escap3d commented 6 months ago

There is an issue where if I use the .votepause or admin command !pause at the start of a round, it does not pause during that same freezetime but instead freezes at the beginning of the next round. Is it possible to implement a pause during that same freezetime and not have it pause at the start of the next round? Additionally, if someone wants to unpause, they should have a command like .voteunpause or unpause so that the round can start again.

SmileYzn commented 6 months ago

Issue? NO! is not.

It's not an issue, match will pause only on next round, and players are unable to cancel pause while running.

Escap3d commented 6 months ago

Issue? NO! is not.

It's not an issue, match will pause only on next round, and players are unable to cancel pause while running. u can not add .voteunpause commmand??

F4ntik commented 6 months ago

The current pause implementation is more like a timeout. Is the classic pause on the server not considered? Or is it not working properly?

Escap3d commented 6 months ago

The current pause implementation is more like a timeout. Is the classic pause on the server not considered? Or is it not working properly?

I want to say that there should be a ".voteunpause" command, just like the ".votepause" command. If someone wants to resume the game right after the pause time ends, they can use this command, and the match should start immediately.

SmileYzn commented 6 months ago

TO be honest why someone will vote this? if teammate players voted to stop?

Jesus christ, it's vote, unvote, revote a lot of votes??

I already understand, but will not implement this mess

F4ntik commented 6 months ago

How I understood his idea and imagined how it should look from the user's point of view. During the pause that was caused by voting, a menu should appear for the team that initiated this pause. There are two items in the menu. Continue and close. Continue to become active no earlier than 10 seconds after the pause is initiated. But yes, the thing is not quite relevant, you can wait for this freezetime