search

Smiley-McSmiles / jellyman

Jellyman is a set of scripts to install/manage and update the jellyfin-combined tar.gz generic linux package
GNU General Public License v3.0
92 stars 4 forks source link

Fixes #54 - Jellyfin Release Grep Fix #55

Closed bzoromski closed 9 months ago

bzoromski commented 9 months ago

The current code for grabbing the latest version of Jellyfin is not working. The existing grep looks for single digit patch numbers: jellyfin_[0-9][0-9].[0-9].[0-9].$architecture. The latest version of Jellyfin is 10.8.13, which has a two-digit patch number. In this PR, I've changed the grep to use a Perl expression that looks for any group of text in between two underscores, followed by the architecture: jellyfin_[^_]+_$architecture.

Additionally, the curl command that pulls in the releases was being brought into a variable; in testing on Ubuntu 22.04 I found only the first line of the page results was being pulled into that variable. Since there's no need to store that as a shell variable I've instead combined the curl command into the existing jellyfinArchive variable line and piped that directly into the grep command.

Smiley-McSmiles commented 9 months ago

Very elegant solution, thank you again for this commit. Hope to see future commits from you. (: