search

SmileyChris / easy-thumbnails

Easy thumbnails for Django
http://easy-thumbnails.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.39k stars 319 forks source link

Add dependency to Django >= 1.2 #32

Closed adamn closed 14 years ago

adamn commented 14 years ago

easy-thumbnails, as an emerging library, should require Django 1.2+ and should be explicit about it in the setup.py file.

SmileyChris commented 14 years ago

I don't see why it needs to be explicit unless there's a requirement. Which there might be, I can't think if it is right now though... I don't mind it not being explicit unless this is the case.

adamn commented 14 years ago

It should at least require django generally, most of the packages are moving in that direction.

SmileyChris commented 14 years ago

Yeah, I guess so. I just seems a bit odd that you'd need to bother putting the dependency for the framework in your application. I'll ask around djangocon to get some opinions :)

SmileyChris commented 14 years ago

I'm not going to bother with this for now. No consensus that this is a good idea.