search

SmileyChris / easy-thumbnails

Easy thumbnails for Django
http://easy-thumbnails.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.38k stars 318 forks source link

Python 3 django 3 #533

Closed jaap3 closed 4 years ago

jaap3 commented 4 years ago

This incorporates the changes from PR #511 by @timgraham and PR #527 by @Mogost and then continues to remove support for Python < 3 and Django < 2.2.

jrief commented 4 years ago

Great! @jaap3 Just a short question, is there a need to remove support for Django-1.11. Django-1.11 works perfectly with Python-3 and since it's a LTS it is still supported until 2020/II. I'm perfectly OK with removing support for Python-2.

jaap3 commented 4 years ago

There's still a bunch of ResourceWarning: unclosed file during the tests. I'll see if I can figure out how to get rid of those.

Mogost commented 4 years ago

@jaap3 Please fix code like 

project = u'easy-thumbnails'

in conf.py in py3 u'' is not needed.

jaap3 commented 4 years ago

@jrief I added back Django 1.11 to the test matrix (it still worked anyway ;)) @Mogost good catch, I now removed all u'' prefixes

jaap3 commented 4 years ago

Thanks for the excellent review and suggestions @Mogost

I'm unable to get rid of the ResourceWarning: unclosed file warnings so I filed a ticket instead (#534).

I now consider this PR done, could you please review it again @jrief?

Mogost commented 4 years ago

@jrief I think this branch should be merged (but we shouldn’t rush with the new release). I prepared another PR (based on this changes), which saves us from unclosed files (ResourceWarning). Also I fix forgotten setup.cfg that produce errors like DeprecationWarning (actually has more to do with this PR, but I see no reason to transfer the changes).

jrief commented 4 years ago

OK. Please retry in your real environments to find potential errors not catched by the unit tests.