search

SmileyChris / easy-thumbnails

Easy thumbnails for Django
http://easy-thumbnails.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.37k stars 312 forks source link

Also test against Python 3.9, 3.10, Django 3.2 and Django main #573

Closed jaap3 closed 2 years ago

jrief commented 3 years ago

won't merge until all dependencies are fixed.

jaap3 commented 3 years ago

Not sure what you mean by dependencies, the only dependencies are Django and Pillow right? Currently easy_thumbnails can be installed with Django 3.2, it just isn't tested against it.

If you mean the test failure, I just forced push a typo fix that should do the trick :)

jaap3 commented 2 years ago

@jrief any chance you can take a look at this again?

jaap3 commented 2 years ago

I've rebased this on master so the tests run on GH Actions. I've also added Python 3.10 and Django's main branch to the test matrix (tests are allowed to fail on the main branch, it's just nice to have an early indication when that happens)

jaap3 commented 2 years ago

@jrief A patch release after merging this PR would be much appreciated. easy-thumbnails is currently blocking the upgraded to the next Django LTS on a couple of our projects.

jrief commented 2 years ago

Would version 2.7.2 be a good release name?

Reason I hesitate to jump on 2.8.0 is, that there is a pending 2.8.0rc0 pre-release which adds (pseudo-)support for SVG to easy-thumbnails. I say pseudo here, because downsizing SVGs doesn't really make sense, but it's handy to be able to pass those images through the thumbnailer.

jaap3 commented 2 years ago

I think 2.7.2 is fine, maybe also include #564? Not much has changed since 2.7.1 so a patch release should be fine.