search

SmileyChris / easy-thumbnails

Easy thumbnails for Django
http://easy-thumbnails.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.38k stars 318 forks source link

Django version compatibility (especially Django 3.2) #574

Closed petrklus closed 2 years ago

petrklus commented 3 years ago

Hi, what are the Django versions supported? Especially curious about 3.2.

I have upgraded a fairly simple project to Django 3.2 and I while I am not getting any errors, I am not getting any images either. Any tips what may be happening?

jrief commented 3 years ago

I haven't had any time yet to test with Django-3.2. Sorry!

petrklus commented 3 years ago

I haven't had any time yet to test with Django-3.2. Sorry!

Anything I can do to help? Happy to run the test suite and report back if slightly instructed how to do so :)

jrief commented 3 years ago

One thing to do is to migrate the test-suite from Travis-CI to GitHub actions, because Travis-CI will be shut down sooner or later. If you can extract the essential parts from the current tests and migrate them, that would be really helpful. Here is a blueprint from one of my newer projects: https://github.com/jrief/django-formset/blob/main/.github/workflows/pythonpackage.yml

jaap3 commented 2 years ago

Just opened a PR to switch to GH Actions (#578), I'll update my other PR that adds Django 3.2 support (#573) once the switch to GH Actions has completed.

jaap3 commented 2 years ago

I believe the recent release is now compatible with Django 3.2

claudep commented 2 years ago

@jrief, I guess this ticket could be closed. By the way, I would appreciate a release allowing Django 4.0. Regarding, the Django upper limit in requirements, I think that either the project is reactive enough to up the limit and release soon after a Django release, or else simply drop that upper limit.

SmileyChris commented 2 years ago

Closing this, and the just released v2.8.1 has Django 4 support. I also entirely removed the django upper limit restriction so it won't break as soon as 4.1 is out 😛 .

claudep commented 2 years ago

Thanks a lot, @SmileyChris !