search

SmileyChris / easy-thumbnails

Easy thumbnails for Django
http://easy-thumbnails.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
1.39k stars 319 forks source link

add forgotten migration file #575

Closed ozmax closed 3 years ago

ozmax commented 3 years ago

The 3rd migration file is not commited to the project. This commit adds the migration file.

jaap3 commented 3 years ago

This only happens when you install easy-thumbnails in a Django 3.2 project. Django has switched the default auto field to BigAutoField. easy-thumbnails is not yet compatible with Django 3.2 so that's why you get this migration file. See also PR #573 and issue #574

ozmax commented 3 years ago

@jaap3 Indeed, thanks for the follow up. Could we just keep the AutoField setting on the easy-thumbnails app config so it will both not create new migrations and it will not conflict with the main django setting the user has chosen? Also, i am currently using the easy-thumbnails app on a django 3.2 project, so if there is something to do or test in order to help, please let me know :)

jaap3 commented 3 years ago

Yes, setting default_auto_field is one of the things I did in PR #573.

I'm not one of the maintainers of this project, I've only contributed every now and then. I cannot tell you what needs to happen before that PR can get merged or an official Django 3.2 supporting version can be released. I think it's mostly in the hands of @jrief, as I believe @SmileyChris has largely abandoned this project.

From issue #574 I understood that help is required to move from Travis to GitHub actions. It's not directly related to getting Django 3.2 support released, but if might help.

jrief commented 3 years ago

Thanks to PR #573 there is no need for this migration anymore.