search

SmingHub / Sming

Sming - powerful open source framework simplifying the creation of embedded C++ applications.
https://sming.readthedocs.io
GNU Lesser General Public License v3.0
1.47k stars 348 forks source link

Change SparkFun_APDS9960 to submodule #2800

Closed mikee47 closed 3 months ago

mikee47 commented 3 months ago

Submodule allows easier maintenance and tracking of upstream changes. Only one function change, addition of getStatusRegister function.

Also patch fixing issue flagged by clang build:

 /home/runner/work/Sming/Sming/Sming/Libraries/SparkFun_APDS9960/SparkFun_APDS9960.cpp:508:32:
warning: result of comparison of constant -1 with expression of type 'uint8_t' (aka 'unsigned char') is always false
[-Wtautological-constant-out-of-range-compare]
                if( bytes_read == -1 ) {
                    ~~~~~~~~~~ ^  ~~