search

SmingHub / Sming

Sming - powerful open source framework simplifying the creation of embedded C++ applications.
https://sming.readthedocs.io
GNU Lesser General Public License v3.0
1.45k stars 349 forks source link

Check if CI issues are due to parallel runs of LWIP2 on Windows. #2815

Closed slaff closed 2 weeks ago

mikee47 commented 2 weeks ago

UPDATE: Not applicable, patch has changed with different commit. Ignore.

I've done a side-by-side comparison of the raw logs from this and a failed build and found the problem. This is from the successful run:

Fetching submodule 'lwip' ...
Submodule 'lwip' (https://github.com/lwip-tcpip/lwip) registered for path 'lwip'
Cloning into 'D:/a/Sming/Sming/Sming/Components/lwip/lwip'...
Submodule path 'lwip': checked out 'e8741da9d2086c0fad6703536e1c6133b8f88512'
Checking patch contrib/ports/unix/port/sys_arch.c...
Checking patch contrib/ports/CMakeCommon.cmake...
Checking patch contrib/ports/win32/sys_arch.c...
Checking patch contrib/ports/win32/pcapif.c...
Checking patch contrib/ports/win32/pcapif_helper.c...
Applied patch contrib/ports/unix/port/sys_arch.c cleanly.
Applied patch contrib/ports/CMakeCommon.cmake cleanly.
Applied patch contrib/ports/win32/sys_arch.c cleanly.
Applied patch contrib/ports/win32/pcapif.c cleanly.
Applied patch contrib/ports/win32/pcapif_helper.c cleanly.

and the failed run:

Fetching submodule 'lwip' ...
Submodule 'lwip' (https://github.com/lwip-tcpip/lwip) registered for path 'lwip'
Cloning into 'D:/a/Sming/Sming/Sming/Components/lwip/lwip'...
Submodule path 'lwip': checked out '86c9f7999150199374d7697fd2eed62dcd9b1afa'
Checking patch contrib/ports/unix/port/sys_arch.c...
Checking patch contrib/ports/CMakeCommon.cmake...
Checking patch contrib/ports/win32/sys_arch.c...
Checking patch contrib/ports/win32/pcapif.c...
Applied patch contrib/ports/unix/port/sys_arch.c cleanly.
Applied patch contrib/ports/CMakeCommon.cmake cleanly.
Applied patch contrib/ports/win32/sys_arch.c cleanly.
Applied patch contrib/ports/win32/pcapif.c cleanly.
mikee47 commented 2 weeks ago

Actually that failed run is from the new lwip version, ignore.

slaff commented 2 weeks ago

I will run this PR three times and if all is ok I will merge it as it is. I know it is not the best solution but better a workaround than having to run manually failed jobs.

mikee47 commented 2 weeks ago

I will run this PR three times and if all is ok I will merge it as it is. I know it is not the best solution but better a workaround than having to run manually failed jobs.

I'm doing the same check but focussed on just the lwip2 component. If it works I'll open a PR.