This PR adds a few fixes for websockets I seem to have kicking about.
Tidy, remove unused websocket strings
wsserver tool missing port argument handling, default is 8000 not 9999
Check return value from http connect()
I can force this to fail by calling 'connect' twice in succession, though I do notice a disparity here. If the http connection is 'processing' then WebsocketClient::connect returns false; however, HttpClientConnection::connect returns true in this situation.
TODO:
[x] Document all the various connect methods and clarify meaning of return value. Outside scope of this PR. See #2829
slaff
commented
1 week ago
This PR adds a few fixes for websockets I seem to have kicking about.
wsservertool missing port argument handling, default is 8000 not 9999Check return value from http
connect()I can force this to fail by calling 'connect' twice in succession, though I do notice a disparity here. If the http connection is 'processing' then
WebsocketClient::connectreturnsfalse; however,HttpClientConnection::connectreturnstruein this situation.TODO:
Document all the variousOutside scope of this PR. See #2829connectmethods and clarify meaning of return value.