This PR updates the three ESP32 BLE libraries and applies some fixes.
NimBLE library (esp-nimble-cpp submodule)
BLEGamepad library (ESP32-BLE-Gamepad submodule)
BLEKeyboard (ESP32-BLE-Keyboard submodule)
There are some unused parameter warnings present (when enabled) which can mask issues. Disabled those warnings for library build (in component.mk) and fixed them so #include files don't cause issues elsewhere. Many warnings come from idf.
Fixed in ESP32-BLE-Gamepad:
ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]. No reason for these not to be const char*. Patched.
This PR updates the three ESP32 BLE libraries and applies some fixes.
esp-nimble-cpp
submodule)ESP32-BLE-Gamepad
submodule)ESP32-BLE-Keyboard
submodule)There are some
unused parameter
warnings present (when enabled) which can mask issues. Disabled those warnings for library build (in component.mk) and fixed them so #include files don't cause issues elsewhere. Many warnings come from idf.Fixed in ESP32-BLE-Gamepad:
ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
. No reason for these not to beconst char*
. Patched.BleConnectionStatus.h 'virtual void NimBLEServerCallbacks::onDisconnect(NimBLEServer*, NimBLEConnInfo&, int)' was hidden [-Woverloaded-virtual=]
. Fixed method implementation, addedoverride
directive.