search

Smirnov75 / ComfyUI-mxToolkit

ComfyUI custom nodes kit
GNU General Public License v3.0
119 stars 5 forks source link

I THINK I fixed the nodes losing connection issue, also another issue with mxSeed #25

Open lordwedggie opened 6 days ago

lordwedggie commented 6 days ago

I think the connection issue is caused by your dynamic switch between float and int? I couldn't find any actual errors so I rewrote your code and divided the sliders to INT and FLOAT, also added a fill bar and a bunch of customization options, it's at: https://github.com/lordwedggie/xcpNodes

Your mxSeed is awesome! I'm using it in all my workflows, however, upon loading a new workflow, the first time you click on the seed it doesn't create a new seed, but launches the queue on the same seed again? It's a minor issue but hopefully it can be fixed. Cheers!

Smirnov75 commented 6 days ago

Yes, it's all due to the int-float switch. There have been issues with this before. Fortunately, the new version of ComfyUI offers more options to help prevent such errors. So, for now, I don't plan to split the nodes, even though it's the easiest and most reliable solution. I've also noticed the mxSeed bug. I'll try to fix it in the near future. P.S. I'm really glad that my nodes are useful to you.

lordwedggie commented 5 days ago

Glad to hear! I'm making a bunch of minimalist sliders and bool buttons, aim is to take as little screen space as possible, all based on your nodes, do you mind if I put them up to share? You will of course be credited and your GitHub linked. Oh btw I've been trying to change the node back ground color, but can only make it work in this.node.onAdded, is there a work around? Thanks and...CHEERS!

Smirnov75 commented 3 days ago

My nodes are distributed under the GPLv3 license, so there are no issues with freely using my code in other projects. Try calling app.graph.setDirtyCanvas(true, true); after changing the bgcolor. This might work in some cases.