Smithay / calloop

A callback-based Event Loop
MIT License
176 stars 34 forks source link

Fix calloop double borrows #110

Closed i509VCB closed 1 year ago

i509VCB commented 2 years ago

Fixes #109

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (df4d918) into master (e7cba58) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   89.22%   89.26%   +0.04%     
==========================================
  Files          17       17              
  Lines        1698     1723      +25     
==========================================
+ Hits         1515     1538      +23     
- Misses        183      185       +2     
Flag Coverage Δ
macos-latest 88.77% <100.00%> (+0.05%) :arrow_up:
ubuntu-latest 87.65% <100.00%> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sources/mod.rs 95.69% <ø> (ø)
src/sys/mod.rs 90.75% <ø> (-0.85%) :arrow_down:
src/loop_logic.rs 90.38% <100.00%> (+1.02%) :arrow_up:
src/sources/ping/pipe.rs 97.10% <0.00%> (-1.45%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chrisduerr commented 2 years ago

I can also confirm that this fixes my issue, so should be good to go hopefully.

kchibisov commented 1 year ago

Might be related to this as well https://github.com/alacritty/alacritty/issues/6487

kchibisov commented 1 year ago

@i509VCB If you don't feel like finishing this PR(some codestyle suggestions from @elinorbgr) , let me know, so I can finish it, since right now it's causing crashes downstream which is frustrating.

i509VCB commented 1 year ago

Yeah feel free to take over the pull request, I seem to have forgotten about this one.

elinorbgr commented 1 year ago

Replaced by #115