Closed notgull closed 1 year ago
Thanks for your PR. It looks like a pretty good addition! Could you add a changelog entry for this addition please?
Base: 88.71% // Head: 89.79% // Increases project coverage by +1.08%
:tada:
Coverage data is based on head (
defaf87
) compared to base (80819fa
). Patch coverage: 98.64% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@vberger Is there anything blocking this from being merged?
Apart for my own availability, no. Thanks!
This PR adds a "block on" function to the
EventLoop
that serves a similar purpose as theblock_on()
function fromasync_io
, where the event loop is polled during periods where the future would normally be blocked. I gated it behind ablock_on
feature, please let me know if it would be better to not gate it.