Closed notgull closed 1 year ago
Patch coverage: 95.94
% and project coverage change: +0.63
:tada:
Comparison is base (
725e16a
) 88.23% compared to head (d9f48fa
) 88.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks like your PR changed some behavior, as a test is no longer passing, and it does not look like a fluke.
Looks like your PR changed some behavior, as a test is no longer passing, and it does not look like a fluke.
Yeah, I misread how the channels work and made it so it only drained 1 Runnable
instead of a chunk of Runnable
s, which messed up the dispatching tests. This should be fixed now.
Right now,
calloop
usesfutures-util
'sFuturesUnordered
type to construct its executor. However,futures-util
has quite a few dependencies. This PR migrates to another implementation based on theasync-task
crate, which is dependency free and builds faster. The implementation also uses fewer synchronization primitives, so it should be faster in theory.I also add
slab
as a dependency, but since #123 also adds it we should be alright here.WIP for now