Smithay / calloop

A callback-based Event Loop
MIT License
176 stars 34 forks source link

Fix the additional lifecycle events to work as documented #149

Closed DJMcNab closed 11 months ago

DJMcNab commented 11 months ago

Required for https://github.com/Smithay/calloop-wayland-source/pull/1.

I think this only needs to be a patch release, as this just brings the behaviour in-line with the docs

kchibisov commented 11 months ago

CI should be fixed after https://github.com/Smithay/calloop/pull/150

elinorbgr commented 11 months ago

:+1: with a rebase & changelog adjusment

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.62% :warning:

Comparison is base (2feb1cf) 86.82% compared to head (a5415ee) 86.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #149 +/- ## ========================================== - Coverage 86.82% 86.20% -0.62% ========================================== Files 14 12 -2 Lines 1806 1624 -182 ========================================== - Hits 1568 1400 -168 + Misses 238 224 -14 ``` | [Flag](https://app.codecov.io/gh/Smithay/calloop/pull/149/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | Coverage Δ | | |---|---|---| | [macos-latest](https://app.codecov.io/gh/Smithay/calloop/pull/149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `?` | | | [ubuntu-latest](https://app.codecov.io/gh/Smithay/calloop/pull/149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/Smithay/calloop/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | Coverage Δ | | |---|---|---| | [src/loop\_logic.rs](https://app.codecov.io/gh/Smithay/calloop/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL2xvb3BfbG9naWMucnM=) | `88.69% <100.00%> (+1.78%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/Smithay/calloop/pull/149/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elinorbgr commented 11 months ago

Perfect thanks!