Smithay / calloop

A callback-based Event Loop
MIT License
177 stars 34 forks source link

Fix coverage testing on the CI #150

Closed kchibisov closed 10 months ago

kchibisov commented 10 months ago

The way coverage is enabled/disabled was changed upstream.

Links: https://github.com/rust-lang/rust/pull/114656

codecov[bot] commented 10 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1c2fd23) 86.82% compared to head (a3501cf) 86.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #150 +/- ## ======================================= Coverage 86.82% 86.82% ======================================= Files 14 14 Lines 1806 1806 ======================================= Hits 1568 1568 Misses 238 238 ``` | [Flag](https://app.codecov.io/gh/Smithay/calloop/pull/150/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | Coverage Δ | | |---|---|---| | [macos-latest](https://app.codecov.io/gh/Smithay/calloop/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `85.86% <ø> (ø)` | | | [ubuntu-latest](https://app.codecov.io/gh/Smithay/calloop/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `86.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | Coverage Δ | | |---|---|---| | [src/error.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL2Vycm9yLnJz) | `0.00% <ø> (ø)` | | | [src/io.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL2lvLnJz) | `73.93% <ø> (ø)` | | | [src/loop\_logic.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL2xvb3BfbG9naWMucnM=) | `86.90% <ø> (ø)` | | | [src/sources/channel.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL3NvdXJjZXMvY2hhbm5lbC5ycw==) | `77.14% <ø> (ø)` | | | [src/sources/mod.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL3NvdXJjZXMvbW9kLnJz) | `95.18% <ø> (ø)` | | | [src/sources/timer.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL3NvdXJjZXMvdGltZXIucnM=) | `86.53% <ø> (ø)` | | | [src/sys.rs](https://app.codecov.io/gh/Smithay/calloop/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#diff-c3JjL3N5cy5ycw==) | `98.49% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kchibisov commented 10 months ago

First time I see coverage test pass on my PR, impressive.

elinorbgr commented 10 months ago

Thanks!