search

Smithay / calloop

A callback-based Event Loop
MIT License
177 stars 35 forks source link

Remove nix from the public API #182

Closed notgull closed 5 months ago

notgull commented 5 months ago

This commit removes nix from the public API. nix has frequent breaking changes due to the large API surface it covers, which makes it a semver hazard to keep it in the public API.

Thus far only two items from nix are exposed: Signal and siginfo. Signal is an enum consisting of most real-life Unix signals. I have replaced it with a hand rolled enum primarily taken from the one in async-signal. For the other case, the Event structure exposes most of the relevant fields. So I've turned these fields into accessors. We can PR more later.

This is a breaking change, but it's in service of avoiding breaking changes in the future.

Closes #179

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.36%. Comparing base (dd30cfe) to head (32e66cd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #182 +/- ## ======================================= Coverage 85.36% 85.36% ======================================= Files 14 14 Lines 1858 1858 ======================================= Hits 1586 1586 Misses 272 272 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.