codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.22%. Comparing base (
5ba1370) to head (2f398bc). Report is 1 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #208 +/- ## ========================================== + Coverage 85.44% 86.22% +0.77% ========================================== Files 13 15 +2 Lines 1876 2069 +193 ========================================== + Hits 1603 1784 +181 - Misses 273 285 +12 ``` | [Flag](https://app.codecov.io/gh/Smithay/calloop/pull/208/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | Coverage Δ | | |---|---|---| | [macos-latest](https://app.codecov.io/gh/Smithay/calloop/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `85.50% <100.00%> (?)` | | | [ubuntu-latest](https://app.codecov.io/gh/Smithay/calloop/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay) | `85.82% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithay#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems 86c6713 broke this. By maintaining a copy of
Ping, the ping source will never returnPostAction::Remove.(I guess we could use more tests to catch things like this...)