search

Smithay / smithay

A smithy for rusty wayland compositors
MIT License
1.88k stars 165 forks source link

`KbdRc` and `SeatRc` are leaked #1422

Open ids1024 opened 6 months ago

ids1024 commented 6 months ago

Looking at valgrind logs of anvil, it seems allocations that are part of KbdRc are never freed when exiting cleanly. It seems Drop is never called on KbdRc or SeatRc.

I think known_kbds needs to use Weak to avoid a reference cycle. I'm still unsure what is preventing SeatRc from being freed...

ids1024 commented 6 months ago

Looks like SeatGlobalData and SeatUserData never get dropped.

ids1024 commented 6 months ago

Or I guess SeatUserData is freed when a client exist before the compositor, but not when the compositor exits with a window open?

PolyMeilex commented 2 months ago

This might have been fixed by: #1516