search

Smithay / wayland-rs

Rust implementation of the wayland protocol (client and server).
MIT License
1.08k stars 123 forks source link

Segfault in libwayland-client #359

Closed Imberflur closed 3 years ago

Imberflur commented 3 years ago

If the wayland clipboard from window_clipboard is dropped while using winit there is a segfault in libwayland-client when the mouse is moved (could also be with other window events).

See https://gitlab.com/veloren/veloren/-/issues/855 gdb-backtrace.txt

kchibisov commented 3 years ago

Could you test https://github.com/Smithay/smithay-clipboard/pull/31 ? I've tested it with some veloren that was crashing before,and it's no longer does that if you patch clipboards to use this branch.

Imberflur commented 3 years ago

I had the user that was seeing the issue test a veloren build with this. Our Cargo.lock was pointing to smithay-clipboard 0.5.2 so before patching in the branch I needed to update the minor version of clipboard_wayland https://docs.rs/clipboard_wayland/0.1.2/clipboard_wayland/ which allowed updating smithay-clipboard. To be thorough I made a build for testing with the updated deps before patching in your branch.

These are the builds:

older clipboard crate: https://gitlab.com/veloren/veloren/-/jobs/896170352/artifacts/download
updated clipboard crate: https://gitlab.com/veloren/veloren/-/jobs/896176166/artifacts/download
updated clipboard crate with fix: https://gitlab.com/veloren/veloren/-/jobs/896176086/artifacts/download

The results were:

older clipboard crate build segfaults, updated clipboard crate build does not segfault, and updated clipboard crate with fix build does not segfault

So it seems like updating might have had an effect. :confused:

My changes for these builds can be found here (each commit corresponds to one of the builds listed above): https://gitlab.com/veloren/veloren/-/merge_requests/1602

Imberflur commented 3 years ago

I think this is resolved.