search

Smithsonian / SuperNOVAS

The Naval Observatory NOVAS C astrometry library, made better
https://smithsonian.github.io/SuperNOVAS/
The Unlicense
13 stars 3 forks source link

Fix tt2tdb() period and improve precision #35

Closed attipaci closed 4 months ago

attipaci commented 4 months ago

Another SuperNOVAS 1.0 oops. Beyond fixing the scaling tt2tdb() now uses the same series tdb2tt() series of the original NOVAS C.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.65%. Comparing base (20564a5) to head (212abc8). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35/graphs/tree.svg?width=650&height=150&src=pr&token=E11OFOISMW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian)](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian) ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== - Coverage 98.65% 98.65% -0.01% ========================================== Files 3 3 Lines 2004 2003 -1 Branches 378 378 ========================================== - Hits 1977 1976 -1 Misses 9 9 Partials 18 18 ``` | [Flag](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian) | `98.65% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian) | Coverage Δ | | |---|---|---| | [src/novas.c](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?src=pr&el=tree&filepath=src%2Fnovas.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian#diff-c3JjL25vdmFzLmM=) | `98.44% <100.00%> (-0.01%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian). Last update [2c387ba...212abc8](https://app.codecov.io/gh/Smithsonian/SuperNOVAS/pull/35?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Smithsonian).