search

Smithsonian / dpo-voyager

DPO Voyager - 3D Explorer and Tool Suite
Apache License 2.0
163 stars 28 forks source link

Use the color wheel to select an annotation color #257

Open sdumetz opened 4 months ago

sdumetz commented 4 months ago

Currently annotations color can only be changed by individually tuning R/G/B sliders.

In the properties panel, colors offer a nice shortcut to change them via the color wheel -the ff-color-button element- (so much more convenient that individual R/G/B buttons should be entirely hidden IMO).

I wanted to fix it myself, but it turns out both trees relies on different components, namely ff-property-view and sv-property-view and I wondered if it was some legacy leftovers or if there was a reason for this still, before I start to mindlessly break things?

gjcope commented 4 months ago

I think it's just legacy. IMO something sv-property-view based would be preferred to avoid relying on changes to the ff libraries. But I agree the color wheel would be great and am open to whatever solution is the cleanest.

sdumetz commented 4 months ago

Ok I'll look into it.

On the matter of the ff-libraries, is there a reason to keep them as submodules instead of including them in the repo? They don't seem to have any relevant external usage?

If possible, this would simplify the some changes (like #250 ) that requires synchronizing multiple submodules.

gjcope commented 2 months ago

The new color wheel implementation is included in the latest release (v0.40.1). But user testing noted that, due to browser-specific implementation, the picker displayed on Android Chrome is sub-optimal and significantly different from other experiences. We may need to rethink the custom picker implementation for consistency purposes. Thoughts?

sdumetz commented 2 months ago

I have no android device on hand to test this so I can't see it. Do you have a screenshot? Is it on all android flavors?

The native color picker doesn't have a lot of styling options so if it doesn't work well enough on some platforms we will have to bring back a custom one.

I won't be able to work on this before the end of may, but if it's required and you can wait, I suppose I could repurpose the old component into the new system as a starting point?

gjcope commented 2 months ago

Initial color picker on Android Chrome:

Secondary window through 'More':

I think it can wait. This is still functional I just don't think it fits the goal of consistency. Unless I'm missing some sort of usability aspect of this implementation...

sdumetz commented 2 months ago

Oh that's an ugly dialog.

I'll try to make a PR with a better solution in a few weeks.