search

Smithsonian / dpo-voyager

DPO Voyager - 3D Explorer and Tool Suite
Apache License 2.0
167 stars 28 forks source link

Options widgets not rendering correctly #277

Closed gjcope closed 4 months ago

gjcope commented 4 months ago

Regression since v0.40.1. Option dropdowns don't display the correct selected value text when being re-rendered. Falls back to the '0' option.

gjcope commented 4 months ago

The is due to comparison of inequal types. https://github.com/Smithsonian/dpo-voyager/blob/b8d21678cc5c6b68063fa790ff0f7e64ee07b937/source/client/ui/PropertyOptions.ts#L99 will never be true after selection.

gjcope commented 4 months ago

Fixed in v0.41.0