search

Smithsonian / dpo-voyager

DPO Voyager - 3D Explorer and Tool Suite
Apache License 2.0
168 stars 30 forks source link

Keep Copyright notices #285

Closed sdumetz closed 4 months ago

sdumetz commented 5 months ago

The document's asset.copyright field is currently always erased on save : the value is hardcoded in CVDocument.

I'd like it to be kept the same through saves as we have multiple sources that have different copyright requirements. A scene modification shouldn't change this field.

Additionally, I'd like to be able to edit the notice in the UI so I propose to add a text field in the collection panel. But maybe that's just me and this would be undesirable for everyone else? I'm OK handling this outside of voyager if necessary as long as it don't get replaced after each scene change.

gjcope commented 5 months ago

This is great, and an important point for supporting collaborators.

Only thing I notice is that maybe the text box should not be indented since it is not active-language dependent.

sdumetz commented 4 months ago

Oh, right. I amended the commit.

Also: rebased on v0.42.0

gjcope commented 4 months ago

Thanks! Merged with https://github.com/Smithsonian/dpo-voyager/tree/rc-43

Note - I think it is a little out of place in the Collection tab, since copyright is not stored in the collection element of the scene file, but we don't really have a better place to put it at the moment. Maybe we consider another scene-level element if more of this sort of data comes up...

sdumetz commented 4 months ago

Note - I think it is a little out of place in the Collection tab, since copyright is not stored in the collection element of the scene file, but we don't really have a better place to put it at the moment. Maybe we consider another scene-level element if more of this sort of data comes up...

Yes. I saw nowhere else to put this and didn't want to add another panel. Collection seemed close enough for now. It should definitely be moved if something better comes up.