Smithsonian / dpo-voyager

DPO Voyager - 3D Explorer and Tool Suite
Apache License 2.0
169 stars 28 forks source link

Mobile autosize not working for video-based media in Articles #307

Open kgschoueri opened 1 month ago

kgschoueri commented 1 month ago

For version 0.43.1, there are some bugs with videos embedded into articles when viewed on a mobile device (tested only on two iPhones).

Another bug for the Kinora Voyager Edition has to do with the max width of videos for both mobile and desktop devices. The width of the video seems to determine the width of the entire article which makes for unreadable articles if the width is greater than c. 350 px for mobiles (see image) and more than c. 1000 px for a 15in laptop screen. This seems to be the case for both videos that are stored in Voyager and those embedded from elsewhere. However, I noticed that this issue isn't present for image-based media. The images auto-resize to the appropriate width depending on the viewing device.

For the Kinora Edition you can view this issue in the articles with videos "Introduction", "Placing a Kinora reel", "Rotating a Kinora reel", "Viewing a Kinora reel" and "Replicating the Kinora viewer" and "Replicating the Kinora reel"

IMG_9416

gjcope commented 1 month ago

We aren't currently supporting standalone videos (see #209) so the these would need to be styled appropriately by hand. Typically you would want to make the width 100% instead of a static value (so that it scales) and auto margins on either side. We will keep this open though for future video support.