search

SmogDr / edar_coursebook

1 stars 0 forks source link

Duplicate section headers #20

Closed SmogDr closed 4 years ago

SmogDr commented 4 years ago

I just noticed that when you click on the "Objectives" link on the side navigation bar (for any chapter), the link takes you to the Objectives for Chapter 2. My guess is that the duplicate section header names (each chapter has an "Objectives" section) is causing this error. Maybe we insert "Ch. x" into the header names for each instance of chapter objectives so that each is unique?

wendtke commented 4 years ago

I haven't been able to reproduce this behavior on either a local or deployed book build. Any more details? Is this happening only in the side panel or within text-based links to the Objective sections?

SmogDr commented 4 years ago

@wendtke I've seen it happen on the website, and in R after a knit, and/or a full build. I think that differentiating section header titles fixes the issue.

When you are at a good stopping point, will you merge your branch back into Master so that I can mess around in each Chapter? The changes I intend to make will likely create a bunch of conflicts for you that can be avoided if you merge, wait, and make a new pull afterwards...

wendtke commented 4 years ago

You can make those changes now. I haven’t made a new branch or PR yet. I was planning and researching for data viz and git yesterday. Let me know when it’s safe to jump back in.

Get Outlook for iOShttps://aka.ms/o0ukef

From: SmogDr notifications@github.com Sent: Thursday, August 6, 2020 8:43:25 AM To: SmogDr/edar_coursebook edar_coursebook@noreply.github.com Cc: Wendt,Kathleen Kathleen.Wendt@colostate.edu; Mention mention@noreply.github.com Subject: Re: [SmogDr/edar_coursebook] Duplicate section headers (#20)

@wendtkehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwendtke&data=02%7C01%7Ckathleen.wendt%40colostate.edu%7C10adcac74f6247025c1d08d83a171390%7Cafb58802ff7a4bb1ab21367ff2ecfc8b%7C0%7C0%7C637323218067671678&sdata=J9UDuWf%2BMWAtoWDkwBOV2QbgoXq%2F3hR%2BnMxv9daObYY%3D&reserved=0 I've seen it happen on the website, and in R after a knit, and/or a full build. I think that differentiating section header titles fixes the issue.

When you are at a good stopping point, will you merge your branch back into Master so that I can mess around in each Chapter? The changes I intend to make will likely create a bunch of conflicts for you that can be avoided if you merge, wait, and make a new pull afterwards...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSmogDr%2Fedar_coursebook%2Fissues%2F20%23issuecomment-669971739&data=02%7C01%7Ckathleen.wendt%40colostate.edu%7C10adcac74f6247025c1d08d83a171390%7Cafb58802ff7a4bb1ab21367ff2ecfc8b%7C0%7C0%7C637323218067671678&sdata=4ypy3yPh9P5v9gzjPN2HSbTpoAsL%2B73oNoM%2FHjmF4eg%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKETYSRTNO7O3ASI3NAGOW3R7K6Q3ANCNFSM4PURGQYA&data=02%7C01%7Ckathleen.wendt%40colostate.edu%7C10adcac74f6247025c1d08d83a171390%7Cafb58802ff7a4bb1ab21367ff2ecfc8b%7C0%7C0%7C637323218067681625&sdata=LYtN4qGqwt%2FTSMc2nOu9z%2BDXIlFs%2Bvc3Ow6aiE7dxzI%3D&reserved=0.

SmogDr commented 4 years ago

@wendtke Ha! Thanks. I suppose I should have checked there first! Stay tuned.

wendtke commented 4 years ago

@SmogDr - I'm branching now. Hope it's okay!

wendtke commented 4 years ago

And it looks like you resolved this issue? I'll close it, but feel free to open it, if it's not done.

wendtke commented 4 years ago

@SmogDr - this is happening again with the "Class Exercises" and "Homework" sections. A workaround is to put the chapter number in front of each. Tomorrow, we can discuss when might a good time to make that change and in which PR.

wendtke commented 4 years ago

I rebased my PR with these changes. It should be fine when we merge.