Smolderforge / issues

Issue tracker for the OLD Smolderforge core. No longer in use since we have migrated to a cmangos-tbc based core.
0 stars 0 forks source link

Proper Spell Delay #297

Open henhouse opened 8 years ago

henhouse commented 8 years ago

Original report by me.


I did some testing, can be seen here: https://youtu.be/-aDFGMnyfqA

How it works on Blackrock(3.3.5 AT): -Every CC is delayed by 150ms(such as Frost Nova, CS, KS, Fear, Cyclone, Gouge, Charge/intercept-stuneffect, Polymorph, Blind etc)

-When a rogue uses vanish it takes 250ms until enemies lose him as their target target(disappear), during this time if a spell/ability is casted(doesn't matter if the spell has travel time or not, when it hits the rogue the stealth will break and it will not be "evaded". However if you're casting a spell that fires "SPELL_CAST_START" such as Frostbolt and the rogue uses vanish prior to the cast being finished, then the cast will not be interrupted until after the 250ms when the rogue disappear(this is done to prevent it from being abused by spamming fireblast when casting frostbolt and that way always breaking vanish for example). However if the rogue uses vanish 0,1 sec before cast finishes for example, making the cast finish when the rogue still is visible due to the 250ms delay, then the spell will not go through, it will say "invalid target" for the caster when the spell finishes.

-If a rogue uses vanish after a CC spell is casted(such as blind or fear) but within the 150ms delay that the spell has before it "lands" on the target, then the rogue will evade the spell completely and stay in stealth.

-When a rogue uses vanish it instantly stop the auto-attacks of everyone that is attacking the rogue(before the 250ms delay). However players can still cast abilities on the rogue during the 250ms delay and they will break his stealth if casted within this time period. vid: https://youtu.be/MtuIH8z9eYE

Basically: If a rogue uses vanish before enemy has casted CC then vanish will break and rogue gets CCed. If rogue uses vanish after CC is casted but within the 150ms delay of the cc spell(rogue can't cast vanish after that point since then he'd already be CC), then the rogue "evades" spell and stays in stealth.

Worth noting is that on Blackrock they've made it so the combat log(server) does not send the info about the spell cast of the CC until after the delay when it lands, this prevents people from creating scripts or being notified by addons such as interruptbar before the spell has landed.

Stealth also does not break for the rogue when he opens up on a target with CS for example until after the 150ms delay when the spell has landed(prevents people from spamming instant spells when they are being opened on).

One last thing, Conflagrate should have a delay of 400ms before it becomes castable after target has received immolate debuff(This is how it currently works on Blackrock and sort of how it was on retail).

Basically remove the existing spell delay that some spells has and the functioning of vanish and replace it with this, AT 3.3.5 had & has a reputation of having mimicked blizzard's mechanics nicely and it feels very smooth.

henhouse commented 8 years ago

Original comment by Darken_Ral (Bitbucket: 557058:31e8645c-27f9-45cb-b8e2-a7b9b61d07dc, ).


doesn't matter if the spell has travel time or not, when it hits the rogue the stealth will break and it will not be "evaded".

It's a bug on Blackrock, spells with projectiles can't break Vanish in any way. But also something was changed in 3.0.2 with the way Vanish working and also with hunter shots. For example before 3.0.2 you could evade hunter's Scatter shot with Vanish and it wouldn't break your Vanish (spell has projectile), but in wotlk Scatter can break your Vanish even through it still has projectile. Furthermore, since 3.0.2 you also can evade AoE CCs with Vanish (for example Psychic Scream) and you won't get CCed (but vanish breaks ofc).

However if you're casting a spell that fires "SPELL_CAST_START" such as Frostbolt and the rogue uses vanish prior to the cast being finished, then the cast will not be interrupted until after the 250ms when the rogue disappear

IIRC, in tbc spell cast doesn't interrupts when your target dissapears until the spell cast isn't over, no?

-If a rogue uses vanish after a CC spell is casted(such as blind or fear) but within the 150ms delay that the spell has before it "lands" on the target, then the rogue will evade the spell completely and stay in stealth.

That is also just a bug. If the spell without projectile got evaded by the vanish - it will break vanish and stealth for sure.

So we have two things in your example: bugged private server which you absolutely can't use as an example (especially AT who are very well known for their bugs and custom balance and changes to game mechanics) and different expansion, which is pretty much completely different game. Blizzard made incredible amount of changes to game mechanics after tbc. Even wotlk prepatch (3.0.2) was completely different from tbc.

ps:

Stealth also does not break for the rogue when he opens up on a target with CS for example until after the 150ms delay when the spell has landed(prevents people from spamming instant spells when they are being opened on).

I reported that bug also, happens due to stealth fade has no delay :(

henhouse commented 8 years ago

"That is also just a bug. If the spell without projectile got evaded by the vanish - it will break vanish and stealth for sure." this I can buy but you stated that spells with projectiles can't break vanish. That's not true, vanish can definitely break from projectiles.

Anyhow, the current system on this server is flawed, only some CCs have delay on them, should at least be applied to all CCs.

henhouse commented 8 years ago

Original comment by Darken_Ral (Bitbucket: 557058:31e8645c-27f9-45cb-b8e2-a7b9b61d07dc, ).


That's not true, vanish can definitely break from projectiles.

Not in TBC, that for sure. In TBC vanish can evade any projectile, same way as you can catch projectiles with Ice Block or Divine Shield, and it doesn't care about number of those projectiles or the moment when they were launched or anything else. Or you have any proofs of the opposite? You probably might show some videos with Deadly Throw breaking vanish, but since ~2.3.3 patch Deadly Throw has instant interrupt effect, which is enough to break vanish effect :)

Anyhow, the current system on this server is flawed, only some CCs have delay on them, should at least be applied to all CCs.

You will be surprised but it's not about CCs, it's about spell casts should have delay and we actually have that delay on every spell. There are flaws with some effects of the spells, not with delay on the spell casts (some should have that delay and we don't have it, like stealth fade, and some spells should not have additional delay, but we have it. For example GT-AoEs have two delays, one on spell cast itself and that correct, but we also have delay on the "effect" of GT-AoE after it affected the ground, which should not be the case => Flare doesn't reveal stealthed / invisible targets instantly and rogues can open into hunter with their shs ability very easy. That should be nearly impossible).