Smoothieware / Smoothie2-old

(Deprecated attempt at) A Smoothie firmware port to the Smoothieboard v2 boards.
GNU General Public License v3.0
34 stars 22 forks source link

Migrating a large portion of the V1 code base #36

Open DouglasPearless opened 8 years ago

DouglasPearless commented 8 years ago

This brings across most of the V1 code base, except for:

and the functions that require them.

wolfmanjm commented 8 years ago

it seems there is a bunch of stuff in here specific to your local directory/workspace. The Segger stuff needs to not be in the main repo IMO, and the .gitignore should not have your personal preferences for what to ignore.

DouglasPearless commented 8 years ago

Hi Jim,

I agree; the .gitignore needs to be itself ignore and not have my stuff in it; will fix.

I will update the makefile to allow a flag for debug and segger so it is only include if the user wants it or there; what do you think?

Sent from my iPhone

On 12/11/2016, at 7:30 PM, Jim Morris notifications@github.com wrote:

it seems there is a bunch of stuff in here specific to your local directory/workspace. The Segger stuff needs to not be in the main repo IMO, and the .gitignore should not have your personal preferences for what to ignore.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

wolfmanjm commented 8 years ago

IMO there should be NO Segger stuff at all in a public open source project. that is private to you and should not be in the makefile or anywhere else publicly. This is true of any personal preferences.

DouglasPearless commented 8 years ago

Hi Jim,

Good point, instead it might be better I write up a "how to" like the Eclipse for the Smoothie website.

I have noticed strange behaviour for my Rotary Delta, specifically the mechanism always goes in the opposite direction for G0 moves; I have read the changes you made for the mirror_xy feature in the code, but that doesn't seem to be it; I have been looking for the cause for the last day; do you have any thoughts of what it might be with all the code changes recently?

( just had a large earthquake here in New Zealand, certainly nice to focus on something else for a while as the city where I live - Wellington, has been shutdown )

Sent from my iPhone

On 13/11/2016, at 8:19 AM, Jim Morris notifications@github.com wrote:

IMO there should be NO Segger stuff at all in a public open source project. that is private to you and should not be in the makefile or anywhere else publicly. This is true of any personal preferences.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

arthurwolf commented 8 years ago

On Sun, Nov 13, 2016 at 9:30 PM, Douglas Pearless notifications@github.com wrote:

Hi Jim,

Good point, instead it might be better I write up a "how to" like the Eclipse for the Smoothie website.

http://smoothieware.org/eclipse ?

I have noticed strange behaviour for my Rotary Delta, specifically the mechanism always goes in the opposite direction for G0 moves; I have read the changes you made for the mirror_xy feature in the code, but that doesn't seem to be it; I have been looking for the cause for the last day; do you have any thoughts of what it might be with all the code changes recently?

( just had a large earthquake here in New Zealand, certainly nice to focus on something else for a while as the city where I live - Wellington, has been shutdown )

Sent from my iPhone

On 13/11/2016, at 8:19 AM, Jim Morris notifications@github.com wrote:

IMO there should be NO Segger stuff at all in a public open source project. that is private to you and should not be in the makefile or anywhere else publicly. This is true of any personal preferences.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Smoothieware/Smoothie2/pull/36#issuecomment-260210372, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGpFeIKrv7hkj9uWJch-Pa5vO57d5EKks5q93N3gaJpZM4KvnT2 .

Courage et bonne humeur.

DouglasPearless commented 8 years ago

Yes,

Like http://smoothieware.org/eclipse http://smoothieware.org/eclipse but for the Segger SystemView and how to get into tracing ISRs, Timers, interrupts etc to see what Smoothie is doing internally.

Cheers Douglas

On 14/11/2016, at 9:34 AM, Arthur Wolf notifications@github.com wrote:

On Sun, Nov 13, 2016 at 9:30 PM, Douglas Pearless notifications@github.com wrote:

Hi Jim,

Good point, instead it might be better I write up a "how to" like the Eclipse for the Smoothie website.

http://smoothieware.org/eclipse ?

I have noticed strange behaviour for my Rotary Delta, specifically the mechanism always goes in the opposite direction for G0 moves; I have read the changes you made for the mirror_xy feature in the code, but that doesn't seem to be it; I have been looking for the cause for the last day; do you have any thoughts of what it might be with all the code changes recently?

( just had a large earthquake here in New Zealand, certainly nice to focus on something else for a while as the city where I live - Wellington, has been shutdown )

Sent from my iPhone

On 13/11/2016, at 8:19 AM, Jim Morris notifications@github.com wrote:

IMO there should be NO Segger stuff at all in a public open source project. that is private to you and should not be in the makefile or anywhere else publicly. This is true of any personal preferences.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Smoothieware/Smoothie2/pull/36#issuecomment-260210372, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGpFeIKrv7hkj9uWJch-Pa5vO57d5EKks5q93N3gaJpZM4KvnT2 .

Courage et bonne humeur. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Smoothieware/Smoothie2/pull/36#issuecomment-260210627, or mute the thread https://github.com/notifications/unsubscribe-auth/ADkh-5phMdyOk58BwijcRIZvFw5ATQHQks5q93Q8gaJpZM4KvnT2.