Smujb / powered-pixel-dungeon

Powered Pixel Dungeon - a mod of Shattered Pixel Dungeon that reworks many aspects of gameplay.
GNU General Public License v3.0
9 stars 2 forks source link

Issues as of 0.4.6 #21

Closed vi closed 4 years ago

vi commented 4 years ago

commit 87c4ac9bbb0e99bea3982c90921d4859f57ba109

vi commented 4 years ago

Your chilling sword is about to degrade

So maybe it's only that red/green line is missing in UI, not the mechanic?

Smujb commented 4 years ago

All known, issues with the port except:

This was an issue with 0.8.1 Shattered actually so I probably forgot to port a commit that fixed it.

Noted.

Damn it. I thought I had fixed that. This issue makes no sense at all.

Certain level types may spawn rooms that have nothing in them and can't be accessed if they have the "town" feeling. This is because they would have been empty space otherwise.

Not really, but due to being a different level, writing interactions between surface and underneath is hard.

Smujb commented 4 years ago

As for the resurfacing in the wrong place issue, I have not been able to reproduce it.

Smujb commented 4 years ago

Was this issue either found in an earlier release or an old save? If not I'll need to do more extensive testing.

Smujb commented 4 years ago

Update: reproduced it. Seems rarer than in previous versions, but still happens. Some levels are completely fine and others are broken. Going to try to fix ASAP.

vi commented 4 years ago

Screenshots:

Wrong marker for the scroll:

1

Bad UI for buying item. May be the same cause as invisible degradation bar.

2

Note that Power Saver is active, but the issue is the same even without power saver and in landscape mode.

vi commented 4 years ago

As of cc0e775ae9d149b7d357a009307df54d2266d2d3, at least some UI issues are fixed.

There is another minor one: bronze lock looks sheared:

3

vi commented 4 years ago

Also drunkedness icon does not fade away in a way that was introduced in the recent Shattered update.

Smujb commented 4 years ago

Icon fading was directly ported - it exists on a buff by buff basis. I added it to Wet but forgot Drunk. Will add

vi commented 4 years ago

(Now realized that there are both "wet" debuff and diving, but they are somehow not connected).

Smujb commented 4 years ago

Seeing as most of these issues were fixed a while ago, I'm going to create a new issue with the title Text for moving between levels (including diving in/out) is often wrong. (the only remaining one) and close this.

vi commented 4 years ago

In future, shall I create series of individual issues (which may have considerable duplicated text) or keep using itemized issues?

Smujb commented 4 years ago

It doesn't really matter; the main thing is that 90% of this issue is no longer relevant so keeping it up makes little sense.