search

Smujb / powered-pixel-dungeon

Powered Pixel Dungeon - a mod of Shattered Pixel Dungeon that reworks many aspects of gameplay.
GNU General Public License v3.0
9 stars 2 forks source link

physical and maybe magical protection doesn't work #35

Closed Xazmadan closed 4 years ago

Xazmadan commented 4 years ago

when i equipped 3 armors on +40% +33% +29% physical defence, enemy still damaged me, like with not armor. Enemys was a: monk, gnoll brute, dm-300, cave spider, all sewers mobs, prison guard, fly swarm.

Xazmadan commented 4 years ago

in previous update i don't receive any physical damage, including damage from Chalice of blood

Smujb commented 4 years ago

I'm pretty sure they stack multiplicatively. I'll look into it but it's not a case of adding the percentages up.

Xazmadan commented 4 years ago

But in that update damage from Chalice of blood is too don't decreased

Smujb commented 4 years ago

Well if it changed between updates that's incredibly odd, as I didn't touch armour code...

Smujb commented 4 years ago

Closing this as they seem to work fine from my testing. There was a bug however where magical and physical damage might apply wrongly to different sources, and this was fixed by https://github.com/Smujb/yet-another-shattered-dungeon/commit/3c66141b1fccf7f72678a820bc9d1fb1b934d857

Smujb commented 4 years ago

It was based on shielding level so the difference you experienced was likely based on whether your shield was full rather than updating the game.