Sn0wCrack / ExHen-Archive

System for crawling/archiving and viewing ExHen galleries
The Unlicense
89 stars 8 forks source link

Add docker as an runnable environment #12

Closed PBXg33k closed 6 years ago

PBXg33k commented 6 years ago

I've migrated all my servers (and roles) on my homelab to docker and thus been porting all servers to be able to run on docker.

This PR adds docker as an additional environment. Using docker-compose only requires one copy action and changes to the docker-compose.override.yml file to have a local running instance

PBXg33k commented 6 years ago

Adding WIP tag as i've discovered some small issues which i'm adressing

Sn0wCrack commented 6 years ago

That's pretty nice, I'm not a docker guy myself, but let me know once you've worked out all the kinks and I'll take a look at merging this in.

PBXg33k commented 6 years ago

Yes, i've got most kinks worked out locally and in my swarm. The biggest challenge was Sphins Search, mostlikely because of lack of experience.

At this moment i'm running manual tests on the docker stack, missing extensions, cronjobs not getting picked up, small stuff like that

PBXg33k commented 6 years ago

@Sn0wCrack Done

Notes: I half arsed the setup for cron in the sphinx container which will run the install with every start, which is no biggy. I didn't want to add extra dockerfiles for an external dependency.

Sn0wCrack commented 6 years ago

Sweet, looks good to me.

Should be fine with the Sphinx setup there honestly so long as it's not touching the data directories you should be right.

Just a couple things:

  1. Would you be able to just squash your commits to keep things a little nicer looking.

  2. With the two small code changes, could you just split those out into a different PR? Once again, like to just keep things a bit better manage (which is rich coming from me with my commit history). I'll put comments on the lines I mean in your PR.

PBXg33k commented 6 years ago

commits squashed. Opening new PR with code changes.

Sn0wCrack commented 6 years ago

All merged in now 👍