search

Snaacky / dndserver

Dark and Darker private server implementation written in Python
The Unlicense
265 stars 60 forks source link

Change header pack format so signed integers don't leak #153

Closed tilkinsc closed 1 year ago

itzandroidtab commented 1 year ago

It is not realy leaking. It is causing the values to be converted to signed integers. So it would show -1 instead of 65535

Snaacky commented 1 year ago

This is intentional. See #70.

tilkinsc commented 1 year ago

You glossed over it too quick. They should both be unsigned, not just one. The values should never dip below 0.