Snaggly / KSW-ToolKit-Service

Hijacks KSW
GNU General Public License v3.0
20 stars 4 forks source link

McuReader fails on service restart #24

Open iulianbute opened 1 year ago

iulianbute commented 1 year ago

i can only restart the service only if i clear data on android settings for the service app (not the client app) fresh full upgrade to ksw 4.0.7 firmware to check if issue persists (with full reset) crashes on service restart, os restart, any restart :) if i clear service data, it starts successfully. ksw-toolkit client v1.2 service version 1.2.1 mcu 0230A0eGS-E39-KTL-BA-211011G System 4.0.7 10-501A-EA-1-... previosly i have used them both without issues (started crashing after updating both client/service while on os 3.9.x)

2 errors i got:

1st: KSW-ToolKit-CoreService: KSW-ToolKit-Service stopped

2nd: KSW-ToolKit-CoreService: Could not start McuReader! [Ljava.lang.StackTraceElement;@54325d6

ocouch commented 10 months ago

I have the same issue.

Service version 1.2.1 Client 1.2 MCU Ver 6150A0eALS-C&C-KTL-DC-230107G App Ver Ksw-S-M600_OD_v1.5.6NEXAI System Ver 12-662EA-868927051813041

Could not start McuReader!

[Ljava.lang.StackTraceElement;@545fcf0

Clearing app data resolves the issue. Clearing cache data does not.

ocouch commented 10 months ago

Tried earlier versions of service with v1.2 of Client.

Issue persists with service version 1.2. Issue disappears with service version 1.1.0.

However, in v1.1.0 am unable to enable Start at Boot setting (gui slider toggles to on, but does not retain setting)

My car did not have an idrive system from factory. I'm not sure if this might be related to the problem?

Snaggly commented 10 months ago

This is probably caused by the ConfigManager trying to parse an incompatible config file and just throws an uncaught exception. This entire manager needs to be reworked for the coming update as the current implementation seems very fragile!

ocouch commented 10 months ago

For now rolling back to both version 1.1 of client and service together seems to be working 👍

Snaggly commented 10 months ago

I refactored that ConfigManager in this commit: https://github.com/Snaggly/KSW-ToolKit-Service/commit/18512a87481469f4a02aadb7b72222184403d5b6

Hopefully with that the riddles of this crash will be fixed.

ocouch commented 10 months ago

I tested out the update with Client v1.2 but no cigar. Still same issue