Add sergeant role (second LEO supervisor)

SnailyCAD / snaily-cadv4

💻 An open source Computer Aided Dispatch (CAD) for FiveM, this is a web based integration for communities who love police roleplaying and dispatching. Discord: https://discord.gg/eGnrPqEH7U

https://docs.snailycad.org/docs/getting-started

MIT License

137 stars 83 forks source link

Add sergeant role (second LEO supervisor) #1949

Open glxgxr opened 4 weeks ago

glxgxr commented 4 weeks ago

Feature

[x] Related issues linked using closes: #number
[x] There is only 1 db migration with no breaking changes.

Translations

[x] .json files are formatted: pnpm format
[x] Translations are correct
[x] New translation? It's been added to i18n.config.mjs

closes #1922

casperiv0 commented 3 weeks ago

Nice PR, though, what's the point if they can use custom roles instead 👀?

Legacy-TacticalGamingInteractive commented 2 weeks ago

Nice PR, though, what's the point if they can use custom roles instead 👀?

This appears to be related to my issue here and permissions: https://github.com/SnailyCAD/snaily-cadv4/issues/1922

The need for another Supervisor option is important for lower level Supervisor so they don't have as much power. (In case someone gets terminated from a Department and then tries to sabotage officers)

jxckUK commented 2 weeks ago

So ultimately another role isn't whats needed (as this can be achieved with custom roles), but additional permission keys so you can split out the "Manage Units" key into less privileged tasks such as the ones you listed?

Manage another Officer's Rank Manage another Officer's Callsign Ability to view Department Time/Duty Logs

Legacy-TacticalGamingInteractive commented 2 weeks ago

Yes exactly

Basically so we can fine tune a few more permissions as needed for security reasons

Legacy-TacticalGamingInteractive commented 1 day ago

Does this one just need to be merged with next update then its good to go basically?