search

SnakeDoc / superD_legacy

A file duplication utility in pure java.
Apache License 2.0
1 stars 3 forks source link

Move Walk() to own class Walker? #11

Closed tracehagan closed 11 years ago

tracehagan commented 11 years ago

Do we want to move the recursive Walk() to its own class?

I might experiment with this in branch thagan

SnakeDoc commented 11 years ago

Hmm...

Maybe we should isolate the different logical units within that method. It's a pretty gnarly method right now: recursive walking, listing directories, validating directories, getting hash, writing to database... perhaps they should all be first broken down into their own methods then a new "driver" method created that brings them all together via method calls... this way we can change each of those components separately without effecting the others (in theory at least! lol). the database stuff is already being handled by DedupeSQL.class (sql.writeRecord() inside of DedupeR.class), and hashing is already taken care of via library.... so that means we have directory validation, listing and walking to separate... thoughts?