search

Snakemake-Profiles / lsf

Snakemake profile for running jobs on an LSF cluster
MIT License
36 stars 22 forks source link

Support quoted jobid from snakemake v7.1.1 #47

Closed mbhall88 closed 2 years ago

mbhall88 commented 2 years ago

Closes #45

mbhall88 commented 2 years ago

You can ignore the failing CI - I've fixed this in #43

mbhall88 commented 2 years ago

I've tested these changes with snakemake v7.1.0 (before issue) and v7.3.0 with identical results

leoisl commented 2 years ago

Works on snakemake v7.3.3 (most recent as of today), on snakemake v7.1.1 (the one that broke), and on snakemake v7.1.0 (i.e. backcompatible with versions that did not quote the jobid). All good, great job, thanks a lot!

codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (1aa7d7b) into master (d7c0d8a) will decrease coverage by 0.16%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   89.12%   88.95%   -0.17%     
==========================================
  Files           6        6              
  Lines         478      480       +2     
  Branches       64       64              
==========================================
+ Hits          426      427       +1     
- Misses         45       46       +1     
  Partials        7        7
Flag Coverage Δ
unittests 88.95% <25.00%> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
{{cookiecutter.profile_name}}/lsf_status.py 84.25% <25.00%> (-0.55%) :arrow_down: