Snakemake-Profiles / lsf

Snakemake profile for running jobs on an LSF cluster
MIT License
36 stars 22 forks source link

Change cluster cancel to a script #56

Closed mbhall88 closed 2 years ago

mbhall88 commented 2 years ago

Added

Changed

I have tested this with a pipeline also. But maybe you want to test it too @leoisl as you're the debugging king 👑

codecov-commenter commented 2 years ago

Codecov Report

Merging #56 (3198c66) into master (19dfe45) will decrease coverage by 1.38%. The diff coverage is 69.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   88.95%   87.57%   -1.39%     
==========================================
  Files           6        7       +1     
  Lines         480      515      +35     
  Branches       64       70       +6     
==========================================
+ Hits          427      451      +24     
- Misses         46       55       +9     
- Partials        7        9       +2     
Flag Coverage Δ
unittests 87.57% <69.44%> (-1.39%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
{{cookiecutter.profile_name}}/lsf_status.py 84.25% <ø> (ø)
{{cookiecutter.profile_name}}/CookieCutter.py 74.19% <66.66%> (-1.81%) :arrow_down:
{{cookiecutter.profile_name}}/lsf_cancel.py 69.23% <69.23%> (ø)
{{cookiecutter.profile_name}}/OSLayer.py 78.26% <75.00%> (-0.81%) :arrow_down:
mbhall88 commented 2 years ago

I don't really get how the OSLayer test coverage has dropped. Looking at the coverage diff it doesn't look like anything reduced 🤷