search

Snakemake-Profiles / slurm

Cookiecutter for snakemake slurm profile
MIT License
126 stars 44 forks source link

Fix sidecar index out of range issues #115

Closed mbhall88 closed 1 year ago

mbhall88 commented 1 year ago

Fixes the issues mentioned in #96 and #113. Used the patch from https://github.com/Snakemake-Profiles/slurm/issues/96#issuecomment-1429260589

percyfal commented 1 year ago

Thanks for the PR @mbhall88! I had just started looking into this but not added any code yet. I was thinking of adding a test, but if the only case this happens is for unseen job ids that may be unnecessary.

I just added some comments regarding the use of --me option, which is unavailable for older slurm versions (#101).

mbhall88 commented 1 year ago

@percyfal I don't see any of the comments you mentioned?

percyfal commented 1 year ago

@percyfal I don't see any of the comments you mentioned?

I guess pressing "Submit review" helps... Better now?