SnakyMz / Space-Travellers-Hub

A website that displays rockets and missions from SpaceX. It also allows user to reserve any rocket/mission and displays them in the My Profile section. Built with React and Redux.
https://space-travellers-hub-y40g.onrender.com/
MIT License
0 stars 0 forks source link

Space Travelers' Hub #25

Closed As1imwe-Mark closed 1 year ago

As1imwe-Mark commented 1 year ago

Project Kanban Board Setup - SpaceX

In this group project, we are two people in the group i.e @SnakyMz and @As1imwe-Mark . We have successfully created the project in our repo and the link for the Group Project is below Space Travelers' Hub

skyv26 commented 1 year ago

Hi @As1imwe-Mark and @SnakyMz,

Good job so far 👍🏻 There are some issues that you still need to work on to go to the project implementation but you are almost there!

STATUS: REQUIRE CHANGES 🔴

Highlights

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms

@skyv26 linkedin-skyv2022 @vrma_aakash @skybrel @skybrel

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

SnakyMz commented 1 year ago

Made changes as suggested: Removed the Team3 from issues. Screenshot 2023-08-28 220429 Screenshot 2023-08-28 220516

skyv26 commented 1 year ago

@SnakyMz Well done! Please ask for the review again from your dashboard.

frank1738 commented 1 year ago

Hi Team,

You can go ahead with your project

Highlights

✅ Tasks are assigned properly

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.