Closed As1imwe-Mark closed 1 year ago
Good job so far 👍🏻 There are some issues that you still need to work on to go to the project implementation but you are almost there!
Mission
and Rockets. Having the unassigned task in your Kanban board actual doesn't make any sense and looks unprofessional to because at the end of the day nobody is going to work on those task and it will left in your Todo card, which is not good idea. Kindly update your issues by either deleting the dragons tasks or assigned dragons tasks to each other too.Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Made changes as suggested: Removed the Team3 from issues.
@SnakyMz Well done! Please ask for the review again from your dashboard.
Hi Team,
You can go ahead with your project
✅ Tasks are assigned properly
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Project Kanban Board Setup - SpaceX
In this group project, we are two people in the group i.e @SnakyMz and @As1imwe-Mark . We have successfully created the project in our repo and the link for the Group Project is below Space Travelers' Hub