search

Snakybo / Clicked

A keybind management addon for World of Warcraft.
GNU General Public License v3.0
30 stars 6 forks source link

changing runes in SoD doesn't trigger spell known check #185

Closed whitter392 closed 7 months ago

whitter392 commented 7 months ago

Describe the bug

spell known seems to work for checking which runes are currently active. however, loading binds based on spell known for runes requires a reload.

Clicked Version

1.14

World of Warcraft Flavor

Classic

Tried with only Clicked enabled

Lua Errors

No response

Reproduction Steps

set a spell known condition for bind based on rune change rune bind is not updated unless you reload

Last Working Version

No response

Screenshots

No response

Debug Output

No response

Snakybo commented 7 months ago

Hey, I don't play SoD so I can't test this myself, but I think I have a patch that should fix this. Would you be able to try the pre-release version to see if it works?

https://github.com/Snakybo/Clicked/releases/tag/1.14.1-beta

whitter392 commented 7 months ago

it works so far! thanks

whitter392 commented 7 months ago

it could use a check when the equipment is changed in those slots in case the rune is different on the other item. idk if it's too complicated. the weakauras spell known trigger does work for this case

Snakybo commented 7 months ago

Good catch, will add that in :)

Snakybo commented 7 months ago

Got another pre-release version that should do that:

https://github.com/Snakybo/Clicked/releases/tag/1.14.1-beta-2