Snakybo / Clicked

A keybind management addon for World of Warcraft.
GNU General Public License v3.0
34 stars 6 forks source link

Add Skyriding/Mounted flag as Load Condition option #214

Open amarino1010 opened 4 weeks ago

amarino1010 commented 4 weeks ago

Is your feature request related to a problem?

Currently, the skyriding abilities, specifically Whirling Surge, are working inconsistently with Clicked-managed keybinds. Not sure why, have done a lot of testing around stuff, but it is frustrating. I have key assignments for 1 through 5 for normal combat abilities, and then also for the skyriding abilities. I've added the skyriding macro condition for the skyriding abilities, and the "not skyriding" to all of the combat abilities, which is tedious and limiting (adding extra characters to the macro, etc).

Describe the solution you'd like

I would like to see a Load Condition flag added for Skyriding, and ideally just for Mounted in general, so I can just not have Clicked keybinds, on 1 through 5 for example, load while mounted/skyriding.

Describe alternatives you've considered

What I've done so far is add the macro conditions, but this adds a ton of extra characters and makes it I can't set up the rest of abilities in the way that I'd like (see third screenshot for an extreme example that shows the complexity that comes up, though I know with druid specifically the bear/cat abilities only need the form condition without the skyriding condition).

Hope it's relatively straightforward to add these load conditions, thanks for a great addon!

Additional context

image

image

image

Snakybo commented 3 weeks ago

Sadly a load condition isn't really possible as bindings can't be loaded or unloaded during combat, and it's possible to enter/exit, or even be in combat (Tindral) while skyriding.

I haven't run into any issues with the current macro conditions myself, can you try placing the skyriding abilities in the same action group as the rest of your abilities?

I have mine set up like this, which doesn't require the "Not skyriding" condition. image

amarino1010 commented 3 weeks ago

Sadly a load condition isn't really possible as bindings can't be loaded or unloaded during combat, and it's possible to enter/exit, or even be in combat (Tindral) while skyriding.

Ah damn, that's too bad.

I haven't run into any issues with the current macro conditions myself, can you try placing the skyriding abilities in the same action group as the rest of your abilities?

I have mine set up like this, which doesn't require the "Not skyriding" condition.

What you suggest works okay for the simplest uses, but anything that has conditions seems to mix up the order of operations, so I end up with, for example, this:

image

image

And so if I happen to be mousing over something, it casts that instead of doing the skyriding ability. Perhaps this is something that can be fixed in the addon? There doesn't seem to be a way to tell Clicked the priority within a single group, which is why I had used the Groups to separate things.

A separate note, the Whirling Surge issue I have found is because the 'macro' tries to call ability 447981 (the 'choice' to have Whirling Surge) instead of ability 361584, the actual movement ability. I get around this by just not selecting an option in the GUI, which ends up defaulting you to Whirling Surge anyways.

image

Aishuu87 commented 2 weeks ago

A separate note, the Whirling Surge issue I have found is because the 'macro' tries to call ability 447981 (the 'choice' to have Whirling Surge) instead of ability 361584, the actual movement ability. I get around this by just not selecting an option in the GUI, which ends up defaulting you to Whirling Surge anyways.

WOW Thanks man, I've been pulling my hair to get why this only spell wouldn't work at all. Tried all the spellID, even deleted all my main char macros in despair to look for conflicting shit.

Btw I run into the same issue as the main topic, and would appreciate something to work around that :/