search

SnapInteractive / mergeatron

A Node.JS bot that automatically runs Jenkins builds for new, and updated, GitHub Pull Requests.
http://snapinteractive.github.com/mergeatron
Apache License 2.0
27 stars 17 forks source link

Update each commit in a Pull Request with a commit status #9

Closed steves closed 11 years ago

steves commented 12 years ago

Currently only the last commit (HEAD) is updated with a commit status. We should be updating each commit that was part of the test with the status. For a new Pull Request this means updating every commit so far and for an updated Pull Request it means updating each new commit.

danielbeardsley commented 12 years ago

That seems incorrect. If a build hasn't been run for a given commit, nothing can be claimed about the build succeeding or not on that commit.

i.e. if a pull has two commits and the first puts the project in a broken state but the second fixes it, only the second commit (the one the build ran on) should be marked as success.

mikesherov commented 11 years ago

I agree with @danielbeardsley. I recommend we close this.

steves commented 11 years ago

Agreed.