search

Snapchat / snap-kit-spm

https://kit.snapchat.com/
MIT License
9 stars 10 forks source link

Version tags are not in 'Semantic versioning' format #2

Closed domagojb closed 2 years ago

domagojb commented 2 years ago

Hey guys!

Thanks for adding SPM support.

I noticed the Tags you put for versioning are in the wrong format. For example, you use v2.0.0 instead of 2.0.0. Because of the v SPM doesn't notice this as an available version when integrating (attached screenshot).

image

Excerpt from the SPM docs:

A package version is a three period-separated integer. An example is 1.0.0. The package version must conform to semantic versioning to ensure that your package behaves in a predictable manner when developers update their package dependency to a newer version.

https://developer.apple.com/documentation/xcode/publishing-a-swift-package-with-xcode

driefler commented 2 years ago

@domagojb this should be fixed now can you please confirm

domagojb commented 2 years ago

Hey, we'll try it out and get back to you, thanks!

drlukas6 commented 2 years ago

Using 2.0.0 works correctly now but another issue pops up after 2.1.0

domagojb commented 2 years ago

Using 2.0.0 works correctly now but another issue pops up after 2.1.0

Thanks @drlukas6 and thanks guys for fixing this.