search

Snapchat / snap-kit-spm

https://kit.snapchat.com/
MIT License
9 stars 10 forks source link

Code signing issue on 2.1.0 and over #6

Closed drlukas6 closed 2 years ago

drlukas6 commented 2 years ago

Hi!

I'm trying to use Snap Kit with SPM by setting Version up to next Major 2.0.0 < ...

Screenshot 2022-07-25 at 13 54 22

Using the setting I receive the following error:

strip /Users/lukassestic/Library/Developer/Xcode/DerivedData/X-gnmdvedcpqlquscspycxdeexqehx/SourcePackages/checkouts/snap-kit-spm/SCSDKCreativeKit.xcframework/ios-arm64_x86_64-simulator/SCSDKCreativeKit.framework/SCSDKCreativeKit: /Users/lukassestic/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip exited with 1

When using the exact version setting, SPM is loaded correctly:

Screenshot 2022-07-25 at 13 55 10

I would assume the issue is with code signing?

domagojb commented 2 years ago

In the merge commit for 2.1.0 it's visible that codesigning has been added to git. This seems unnecessary since the framework is re-signed by the App.

driefler commented 2 years ago

This has been fixed in 2.3.1 release

domagojb commented 2 years ago

Hey, I tried the version 2.3.1 and the error still persists. 

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -S /Users/domagoj/Library/Developer/Xcode/DerivedData/PhotoMath-ghfqvycainracbcjymfvyaxpawkt/SourcePackages/checkouts/snap-kit-spm/SCSDKLoginKit.xcframework/ios-arm64_x86_64-simulator/SCSDKLoginKit.framework/SCSDKLoginKit -o /Users/domagoj/Library/Developer/Xcode/DerivedData/PhotoMath-ghfqvycainracbcjymfvyaxpawkt/Build/Products/Debug-iphonesimulator/Photomath.app/Frameworks/SCSDKLoginKit.framework/SCSDKLoginKit /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: fatal error: file not in an order that can be processed (link edit information does not fill the __LINKEDIT segment): /Users/domagoj/Library/Developer/Xcode/DerivedData/PhotoMath-ghfqvycainracbcjymfvyaxpawkt/SourcePackages/checkouts/snap-kit-spm/SCSDKLoginKit.xcframework/ios-arm64_x86_64-simulator/SCSDKLoginKit.framework/SCSDKLoginKit (for architecture x86_64)error: strip /Users/domagoj/Library/Developer/Xcode/DerivedData/PhotoMath-ghfqvycainracbcjymfvyaxpawkt/SourcePackages/checkouts/snap-kit-spm/SCSDKLoginKit.xcframework/ios-arm64_x86_64-simulator/SCSDKLoginKit.framework/SCSDKLoginKit: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip exited with 1 (in target 'PhotoMath' from project 'PhotoMath')

I'm guessing this has to do with actually code signing existing in the first place. These code sign resources have been present since version 2.1.0.

jordanperry commented 2 years ago

+1 still having this issue. This is more apparent now that bitcode is being turned off starting with Xcode 14.