Snapmaker / Luban

An easy-to-use 3-in-1 software tailor-made for Snapmaker machines.
https://snapmaker.com/snapmaker-luban
GNU Affero General Public License v3.0
445 stars 120 forks source link

Bug: Slow performance in Luban 4.3 #1601

Open imh1kiko opened 2 years ago

imh1kiko commented 2 years ago

🐞 bug report

Affected Version(s)

Version 4.3

Is this a regression?

The previous version (4.2) ran just fine. Now the UI is hanging.

To Reproduce

Steps to reproduce the behavior:

Case 1

  1. Go to workspace
  2. Connect
  3. Printer has already connected, Luban is still hanging.

Case 2

  1. Click on generate Gcode.
  2. GCode generation takes longer.

Case 3

  1. While printing (lasering, in my case), go back to 3d/laser/cnc tab.
  2. Now go back to workspace.
  3. Luban freezes, resumes after a good while.

Case 4

  1. In workspace, click on sliders ("LED strip", "Exhaust fan", "Door detection")
  2. Wait for it to actually toggle it

Expected behavior Better performance. In 4.2 latest release, everything was snappy.

🌍 Your Environment

jane-rose commented 2 years ago

Ok, we will check for this soon.

jane-rose commented 2 years ago

We can only reproduce case 1, and it will be fixed in subsequent versions. Others are consistent with the 4.2 version or we cannot reproduce. Any futher progress or information can update here.

imh1kiko commented 2 years ago

Following up on the issue. The toggling buttons is very unstable in 4.3. I stopped observing change beyond few minutes. Video is sped up, not to waste time. Case #1, #3 and #4 are shown here.

jane-rose commented 2 years ago

Ok, now we can reproduce case3, and we will re-check case4. But the reason is not slow performance but reconnect action when switching page. (You can temporarily turn off the auto-connect checkbox to solve it .)All these will be fixed in subsequent versions. Thanks for your help.