search

SnapshotSerengetiScienceTeam / DataManagement

Scripts and issues to manage the SnapshotSerengeti images and metadata.
GNU General Public License v2.0
0 stars 0 forks source link

Time Stamp Cleaning #22

Closed meredithspalmer closed 9 years ago

meredithspalmer commented 9 years ago

I get an error running the function MajorCheck() for Season 8 (see code in "Time Stamp Cleaning" file). I'm getting an error because I don't have a file called "seasons.csv", and I was unsure of the contents of this file and thus unable to recreate it. Looking through the script, this file doesn't seem to actually be used for anything (?) which left me confused. Despite getting an error, R still outputs a RollSummary, which I need to proceed with the cleaning. I was simply wondering: a) is "seasons.csv" used in any way and if so, can I get that file and b) if not, can I just proceed using the RollSummary outputted.

mkosmala commented 9 years ago

Sure enough. I don't see seasons.csv being used, either. I imagine Ali originally was going to compare timestamps to the approximate season start and end points. But it's not done currently.

Two options: 1) remove that line from the cleaning file 2) add in an actual check based on season start and end dates. In this case, you'll want to create a seasons.csv file that looks something like this

season, start, end
8, 01-01-2014, 01-07-2014

or whatever the actual start and end dates were.

FYI, we'll need to have start and end dates to add to the database anyway. So knowing what those are will be useful a short ways down the road.

meredithspalmer commented 9 years ago

Sure thing - I can add in that check fairly easily. Thanks!

mkosmala commented 9 years ago

Ok, after you've added in that check and it works okay, you can "close" this issue by clicking the "Close and comment" button at the bottom of this issue.

aliburchard commented 9 years ago

Yep, that was my intention, but looks like I never actually implemented it. Probably a good check to add (I made that script in a hurry - apologies Meredith, it's not fantastic). Perhaps a good idea to start a thread for future improvements to the flagging/check scripts? On my list of things to do is improve the process - perhaps as a Python coding project.