search

SnarpleDev / Snazzle

A better frontend for Scratch, built by the community, for the community
https://snarpledev.github.io/Snazzle/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

migrate to sqlite #42

Closed ajskateboarder closed 1 year ago

ajskateboarder commented 1 year ago

Personally Supabase is a little overkill for what is basically a key value store for Snazzle. SQLite is much better for this

I also fixed Scratch Auth so that it redirects and authenticates correctly (it wasn't doing that before)

Somebody should also test if it works on Replit

Fixes #39 :rocket::rocket::rocket::rocket::rocket::rocket:

redstone-dev commented 1 year ago

Oh thank you!! Will merge when I get back from where I'm going

redstone-dev commented 1 year ago

Screw it, ima fix the merge conflicts now

Screw family bonding time (jk)

redstone-dev commented 1 year ago

Actually nvm, we just merged #44, so I think this is kind of... I can't find the word but like unneeded??

I'll hold it to a vote, it seems wrong to have just me merging this after merging #44...

Sorry about that.

davidtheplatform commented 1 year ago

Also @ajskateboarder your autoformatter deleted a bunch of stuff and I think you committed files in the .gitignore

If we do end up migrating to SQLite it should be in a different PR

ajskateboarder commented 1 year ago

Actually nvm, we just merged https://github.com/redstone-scratch/Snazzle/pull/44, so I think this is kind of... I can't find the word but like unneeded?? I'll hold it to a vote, it seems wrong to have just me merging this after merging https://github.com/redstone-scratch/Snazzle/pull/44...

I'll see what I can do. I personally think SQLite is much easier to use, and Python even supports out of the box Forgot to also mention that I made some QOL changes to the scratch-auth functions (silly me always forgetting what changes i made)

Also @ajskateboarder your autoformatter deleted a bunch of stuff and I think you committed files in the .gitignore

Oh whoops I use super opinionated stuff for Python, I'll remove the vscode config

redstone-dev commented 1 year ago

lgtm

davidtheplatform commented 1 year ago

Everyone remember to auto format your code before you make a pr (ctrl+alt+f in vscode)

On Wed, Aug 2, 2023 at 06:49 RedstoneScratch @.***> wrote:

Merged #42 https://github.com/redstone-scratch/Snazzle/pull/42 into main.

— Reply to this email directly, view it on GitHub https://github.com/redstone-scratch/Snazzle/pull/42#event-9987150478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL2FCVDPZD5JK6ZWBBW7RP3XTI5EBANCNFSM6AAAAAA3AFVLQI . You are receiving this because you commented.Message ID: @.***>