search

SnaveSutit / origins-mod-vscode-extension

MIT License
8 stars 3 forks source link

[BUG] A few potential bugs (or my skill issues) #53

Open ThDilos opened 3 weeks ago

ThDilos commented 3 weeks ago

Describe the bug

  1. Entity Condition "origins:gamemode" does not show suggestions in the field "gamemode"
  2. Damage Condition "origins:name" has a wrong set of suggestions in the field "name", it appears to use the suggestions for the field "damage_type" from Damage Condition "origins:type", which cannot be used. The correct list here. And it's mad about me using the correct one :(
  3. Entity Condition "origins:inventory" does not have a hyperlink attached to its introduction when mouse hovering
  4. "type" in Recipe Datatype is using origins/apoli as prefix, which cannot be used and should be minecraft instead.

Potential Skill Issues:

  1. I cannot use this plugin without a VPN :( It shows unable to load schema This didn't happen before Plugin Version 2.2.0 My guess is my ISP banned certain types of connection
  2. When you have too many certain stuff (idk what the stuff is, either keyword "type" or curly brackets or others) inside a square bracket, the plugin stopped showing suggestion and quickfills completely. There is a certain limit. Attached file marked the limit (at least in my machine).

To Reproduce As explained above

Expected behavior

  1. Show suggestions for field "gamemode".
  2. Correct "name" field suggestion and error marking
  3. Attach a hyperlink to the description
  4. Correct recipe datatype
  5. idk, ig I just continue using VPN if unfixable
  6. No Limit..?

Screenshots No Gamemode Suggestion Damage Condition Inventory Condition Recipe Other cannot be used Unable to load Example File showing the limit: plugin_uplimit.json Video Demonstration: https://github.com/user-attachments/assets/39c44de7-ed82-4b5f-b7fc-6a5c188d5d68

SnaveSutit commented 3 weeks ago

I can't do anything about the VPN requirement, as the connections are from internal VSCode code trying to grab the external JSON Schemas that provide the structures of the JSON files. 😞

I cannot reproduce the failure to produce suggestions at the end of a long file. It may just be that VSCode is limiting it in order to not tank performance? I'm not sure.

The other issues look like oversights or mistakes, so I can take care of those in a few days.

Snapshotlight commented 1 week ago

Sadly I found that even with a VPN it is still impossible for me in China mainland to use this plugin. I'm wondering if the VPN is useable for the connections in VS Code.

ThDilos commented 1 week ago

Sadly I found that even with a VPN it is still impossible for me in China mainland to use this plugin. I'm wondering if the VPN is useable for the connections in VS Code.

I use Netch, it even has a preset for VS Code But you'd need a proxy server first :/

SnaveSutit commented 1 week ago

You could download this repo: https://github.com/SnaveSutit/origins-mod-json-schemas, and manually connect the JSON Schemas to your VSCode: https://code.visualstudio.com/docs/languages/json#_json-schemas-and-settings