search

Snawoot / postfix-mta-sts-resolver

Daemon which provides TLS client policy for Postfix via socketmap, according to domain MTA-STS policy
MIT License
120 stars 23 forks source link

Some FreeBSD rc.d improvements #9

Closed Kernel-Error closed 5 years ago

Kernel-Error commented 5 years ago

Purpose of proposed changes

I add some rc.d improvements

smortex commented 5 years ago

@Kernel-Error are you working on a port for this program? I have a local port not yet committed to the FreeBSD ports tree yet (because of some dependencies AFAICR, but I am back from vacations and have to catch on on many things :upside_down_face:). My local rc.d script is quite different from the one included in the repo. Beside the variable names without the _daemon part, the main focus is the possibility to use a custom PREFIX (%%PREFIX%% instead of an hardcoded /usr/local).

@Snawoot do you think such change make sense in the project itself (change /usr/local/ to %%PREFIX%% and the port only has to copy the contrib file to the right location after doing the substitution) or do you prefer to ship a working sample rc.d file usable on FreeBSD but which is not used by the FreeBSD port system itself?

Snawoot commented 5 years ago

Hello, @smortex!

I think having working script with /usr/local/ path in project itself is better, because some people may prefer to install via pip, wheel etc . Also I suppose it is convenient for port maintainer to have separate init script, because then he will not depend on upstream to update his port. But I don't have strong opinion on it. If porting best practices require some additional files in repo, then OK, send PR.

smortex commented 5 years ago

It makes sense for pip users I guess. Thanks!

I'll review the changes I have and if I think some of them or worth upstreaming, I'll open PRs :wink: